Simon Podlipsky

Thanks for input, will adapt the PR On Thu, Mar 10, 2022, 17:24 Sergei Morozov ***@***.***> wrote: > Looks good in general. I believe, the same idea applies to the...

@morozov I believe changing ```diff - public function exec(string $sql): int; + public function exec(string $sql): int|string; ``` results in hard BC break since I'll have to remove the type...

Ok so I keep :int but add @return int|string? On Fri, Mar 11, 2022, 00:43 Sergei Morozov ***@***.***> wrote: > No, but it should be possible to add a @return...

@morozov what about `PHPDoc tag @return with type int|string is not subtype of native type int.` phpstan errors?

@doctrine what do you think about @Seldaek' comment

What is your feedback on https://github.com/doctrine/dbal/pull/5334 then?

``` WARNING in ../.yarn/__virtual__/@graphiql-toolkit-virtual-952b477400/0/cache/@graphiql-toolkit-npm-0.6.0-d39851cf7b-19878d8e3c.zip/node_modules/@graphiql/toolkit/esm/create-fetcher/lib.js 60:33-54 Module not found: Error: @graphiql/toolkit tried to access graphql-ws (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous...

Running `yarn install` ``` ➤ YN0000: ┌ Post-resolution validation ➤ YN0069: │ @graphiql/toolkit ➤ peerDependencies ➤ graphql-ws: This rule seems redundant when applied on the original package; the extension may...

Tmp fix is `yarn add graphql-ws` + in .yarnrc.yml ```yml packageExtensions: # awaiting fix: https://github.com/graphql/graphiql/issues/2428 "graphiql@*": peerDependenciesMeta: graphql-ws: optional: true ```

@yoshiakis just tried and still getting that issue `graphql-ws` is required but also need to have the package extension. Do you use pnp?