silx-kit
silx.gui: support imageaggregate in _plot2d
Checklist:
- [ ] The PR title is formatted as:
<Module or Topic>: <Action> <Summary>(see contributing guidelines)
This PR enables:
- [x] ImageAggregate filters on _plot2dview
- [x] ImageAggregate filters on Nexusimageview
- [ ] ImageAggregate filters on ComplexView
- [x] ImageAggregate filters on StackView
Not sure if the slot _aggregationModeChanged and setAggregatedImage are well placed into into the class Plot2View
how about this approach? If yes, I will use it for the rest of the classes
About the _ComplexImageView class, the setData method updates the array and also the Complex mode, so I'm not sure how to implement the filter without changing the ImageComplexView class
Do you mean adding the Aggregation items in the class where the self._plot is? (StackView and ArrayImagePlot as you said)
In the case of _Plot2dView the plot is what is called widget, but yes, _Plot2dView is the class creating the plot anyway
Check it if I understood correctly
Do you mean adding the Aggregation items in the class where the self._plot is? (StackView and ArrayImagePlot as you said)
Yes, StackView and ArrayImagePlot which are the widgets that create and add/remove the ImageAggregatedItem to the plot (there is not necessarily a self._plot in there). Doing so will make those widgets self-consistent.
I made a PR on your branch with a few updates/fixes: https://github.com/EdgarGF93/silx/pull/3 I let you review it and merge if you agree with it, else let's discuss it.
Apart from that, this looks good to me! Thanks for the work and your patience !