silx icon indicating copy to clipboard operation
silx copied to clipboard

`silx.gui`, silx view: Updated default Qt binding to `Pyside6`; CI: Updated config

Open t20100 opened this issue 1 year ago • 3 comments
trafficstars

Checklist:


This PR proposes to change the Qt binding priority list to use PySide6 as the default binding. It also uses PySide6 to generate the Windows executable.

This is worth a major version bump for the next release IMO.

TODO:

  • [ ] Test Windows application
  • [ ] Make sure it is OK to use manylinux_2_28

related to #4135, closes #4168

t20100 avatar Sep 03 '24 09:09 t20100

CI seg fault with PySide (see PR #4169 for a fix)

t20100 avatar Sep 03 '24 10:09 t20100

The release workflow is updated to work with PySide6 as the default Qt binding.

Indeed:

  • Qt6 requires extra system packages
  • PySide6.4 (the minimum required version) requires manylinux_2_28, i.e. Debian 10+, Ubuntu 18.10+.

So with this PR, wheels available on pypi will be manylinux_2_28 instead of manylinux_2014.

It also adds --fail-on-warning when building the documentation to avoid generating the documentation when a module cannot be imported.

t20100 avatar Sep 04 '24 12:09 t20100

In order to avoid copy/paste between CI and release workflows, this PR adds a setup-system composite action.

t20100 avatar Sep 05 '24 11:09 t20100

It should be OK to use manylinux_2_28 (AlmaLinux 8 based):

Toolchain: GCC 14
    x86_64 image: quay.io/pypa/manylinux_2_28_x86_64
    aarch64 image: quay.io/pypa/manylinux_2_28_aarch64
    ppc64le image: quay.io/pypa/manylinux_2_28_ppc64le
    s390x image: quay.io/pypa/manylinux_2_28_s390x
Built wheels are also expected to be compatible with other distros using glibc 2.28 or later, including:
    Debian 10+
    Ubuntu 18.10+
    Fedora 29+
    CentOS/RHEL 8+

t20100 avatar Mar 21 '25 16:03 t20100