[2.1.0] pointer ‘peaks0’ may be used after ‘realloc’ [-Wuse-after-free]

[picca]

Hello, while preparing the Debina package of 2.1.0, I got this warning about realloc

src/silx/math/fit/peaks/src/peaks.c: In function ‘seek’:
src/silx/math/fit/peaks/src/peaks.c:210:36: warning: pointer ‘peaks0’ may be used after ‘realloc’ [-Wuse-after-free]
  210 |                             *peaks = peaks0;
      |                             ~~~~~~~^~~~~~~~
src/silx/math/fit/peaks/src/peaks.c:206:41: note: call to ‘realloc’ here
  206 |                         realloc_peaks = realloc(peaks0, max_npeaks * sizeof(double));
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/silx/math/fit/peaks/src/peaks.c:211:41: warning: pointer ‘relevances0’ may be used after ‘realloc’ [-Wuse-after-free]
  211 |                             *relevances = relevances0;
      |                             ~~~~~~~~~~~~^~~~~~~~~~~~~
src/silx/math/fit/peaks/src/peaks.c:207:46: note: call to ‘realloc’ here
  207 |                         realloc_relevances = realloc(relevances0, max_npeaks * sizeof(double));
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Cheers

Fred

[t20100]

Thanks for the report!

Which version of gcc was used? 14?

PR #4147 might fix this. Is there an easy to set-up environment where I could test this?