silx icon indicating copy to clipboard operation
silx copied to clipboard

Remove Qhull from third_party and use scipy

Open t20100 opened this issue 3 years ago • 3 comments
trafficstars

What about removing the copy of scipy's QHull Delaunay wrapper in silx.third_party and use scipy directly? scipy can be kept optional by disabling features based on its availability.

That would simplify setup.py and specific stripping for Linux packaging (see #3674).

t20100 avatar Sep 19 '22 14:09 t20100

But it would heavily impact scatter plot visualization, wouldn't it?

vasole avatar Oct 18 '22 12:10 vasole

Is https://matplotlib.org/stable/api/tri_api.html#matplotlib-tri worthy? I think you already evaluated it.

vasole avatar Oct 18 '22 12:10 vasole

If scipy is not present, it would remove the SOLID visualization mode out of: https://github.com/silx-kit/silx/blob/65eeb0ecadd49666509c8ad92c365c4a49ce11ad/src/silx/gui/plot/items/scatter.py#L276-L280

Yes, I tried it, but it was some 5 years ago and I didn't documented the outcome enough at that time (#1326). I recall having trouble running it in a separated thread, but not sure.

t20100 avatar Oct 19 '22 07:10 t20100