silx icon indicating copy to clipboard operation
silx copied to clipboard

Published 20 hours ago • verified publisher icon silx-kit

rework fabioh5

Open juliagarriga opened this issue 6 years ago • 3 comments

follows the PR #2735

juliagarriga avatar Sep 24 '19 10:09 juliagarriga

Was this closed by #2735?

vasole avatar Oct 18 '19 07:10 vasole

I would say yes, or we have to be a little more verbose on what it is requested to close it.

I think the idea was to rework some things to avoid to convert many time the same numbers. But that's detail i think.

vallsv avatar Oct 18 '19 07:10 vallsv

It was created due to what @vallsv said in PR #2735 :

  • Fix precision for scalar in many frames (1)
  • Fix precision for list of numbers (2)
  • Fix precision for list of numbers in many frames (3) It would be good to rework this code to allow to take care of the three use cases (1) (2) (3) in specialized functions. This could create a more readable code.

I think it is not very important, but @vallsv knows better. If it is too much time consuming or no one has the time we can close the issue.

juliagarriga avatar Oct 18 '19 09:10 juliagarriga