fabio icon indicating copy to clipboard operation
fabio copied to clipboard

Signed floats cbf

Open maggie-klureza opened this issue 1 year ago • 1 comments

Currently, FabIO does not recognize signed floats as valid data type for .cbf files, only integers. However, floats are a legitimate possibility for the CBF standard, so I have added two lines to DATA_TYPES to accommodate this.

maggie-klureza avatar Jun 28 '23 10:06 maggie-klureza

I am not sure this is enough: yes float CBF are possible but we have been focusing on files produced by Pilatus detectors. One would need in addition to have the different compression schemes as described in https://www.iucr.org/__data/iucr/cif/software/cbflib/CBFlib_0.7.9/doc/CBFlib.html Also, in the conversion between formats, CBF is a format declared accepting only integers: https://github.com/silx-kit/fabio/blob/main/src/fabio/converters.py#L63

kif avatar Jun 29 '23 15:06 kif