erlcass icon indicating copy to clipboard operation
erlcass copied to clipboard

Create Keyspace if missing option

Open cleaton opened this issue 4 years ago • 3 comments

cleaton avatar Jan 24 '21 16:01 cleaton

Maybe it's preferable to always first connect without keyspace and run the keyspace creation CQL before connecting to the keyspace.

cleaton avatar Mar 07 '21 10:03 cleaton

Hi @silviucpp , what do you think of this PR? It would be useful for us. Is there a change that you want done?

csrl avatar Oct 15 '21 22:10 csrl

This PR needs a bit of changes.

First we need to get rid of representing strings as lists.there are few places like the following (_ -> "")

            Keyspace = case erlcass_utils:get_env(keyspace) of
                {ok, Space} -> Space;
                _ -> ""
            end,

In the entire library we are working with binary strings and I want to keep it consistent.

Also this PR doesn't have a unit test added for this case.

In case this things are fixed I can merge it

silviucpp avatar Oct 16 '21 00:10 silviucpp