django-pwa icon indicating copy to clipboard operation
django-pwa copied to clipboard

Fix sizes property name to size in README

Open PetrDlouhy opened this issue 2 years ago • 1 comments

Fix #38 The sizes property name in README doesn't match with the code, where is it named size: https://github.com/silviolleite/django-pwa/blob/0ff60e7afaf23d6883d593554b93e54bb56e41fe/pwa/templates/pwa.html#L19

PetrDlouhy avatar Nov 11 '21 05:11 PetrDlouhy

I believe this should be fixed in pwa.html, instead of in the readme. The icon property should be called sizes, as this also injected into the manifest.json and here it should be sizes, as can be seen on MDN Web Docs

JelleBootsma avatar Nov 16 '21 16:11 JelleBootsma