django-pwa icon indicating copy to clipboard operation
django-pwa copied to clipboard

Replace django.conf.urls.url with django.urls.re_path

Open samueljsb opened this issue 3 years ago • 1 comments

This avoid a deprecation warning: django.conf.urls.url is an alias for django.urls.re_path but will be removed in Django 4.0.

This method was only added in Django 2.0, so we have to check whether we are using a version of Django greater than 2.0 before we import it. Otherwise, we use the old url method.

Fixes #68

samueljsb avatar May 05 '21 11:05 samueljsb

Codecov Report

Merging #69 (b4144e9) into master (0ff60e7) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           51        54    +3     
=========================================
+ Hits            51        54    +3     
Impacted Files Coverage Δ
pwa/urls.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ff60e7...b4144e9. Read the comment docs.

codecov-commenter avatar May 05 '21 11:05 codecov-commenter

No longer needed -- this was done by #88.

samueljsb avatar Nov 03 '22 22:11 samueljsb