django-pwa icon indicating copy to clipboard operation
django-pwa copied to clipboard

Published 20 hours ago • verified publisher icon silviolleite

Update pwa.html

Open blackelbow opened this issue 5 years ago • 3 comments
trafficstars

Include crossorigin to prevent 401 when pwa is behind sign in

blackelbow avatar Mar 16 '20 19:03 blackelbow

Hey @silviolleite , I'd like to see this PR reviewed & merged. Without this, django-pwa is not usable in any reverse proxy or auth scenario.

Code changes are only one line.

Archmonger avatar Mar 21 '21 09:03 Archmonger

Hey @silviolleite , I'd like to see this PR reviewed & merged. Without this, django-pwa is not usable in any reverse proxy or auth scenario.

Code changes are only one line.

Thx @Archmonger Please, you need to fix the unit tests.

silviolleite avatar Mar 29 '21 13:03 silviolleite

@silviolleite I am not the author for this PR, and the original author appears to be inactive on GH.

The fix for the unit test is quite simple. Line 25 of test_template_tags.py needs to be changed. Previously was: '<link rel="manifest" href="/manifest.json">', Needs to be '<link rel="manifest" href="/manifest.json" crossorigin="use-credentials">',

Tests will pass after this change.

Archmonger avatar Mar 31 '21 23:03 Archmonger