reactivated icon indicating copy to clipboard operation
reactivated copied to clipboard

Asset file names are being replaced by 'renderer'

Open agusmao opened this issue 2 years ago • 6 comments

I've been having an issue with SVGs not inlined, where their server side rendered result is coming as rendered<some_id>.svg (which does not exist).

This merge request tries to address this issue.

print

agusmao avatar Apr 17 '24 15:04 agusmao

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Apr 17 '24 15:04 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA. If applicable, I have secured permission from my employer.

agusmao avatar Apr 17 '24 15:04 agusmao

recheck

agusmao avatar Apr 17 '24 15:04 agusmao

Looks right to me, do you have a minimal reproduction or way for me to try out the fix before/after?

@crgwbr have you run into this?

silviogutierrez avatar Apr 17 '24 15:04 silviogutierrez

I haven't seen this bug myself—for example: view-source:https://www.thelab.co/. the requested change looks fine, but would also be interested in seeing reproduction steps.

crgwbr avatar Apr 17 '24 16:04 crgwbr

@agusmao : I think this fix can likely go in, but I think the problem is you're using Vite to handle your static SVGs, etc.

Why don't you put them outside in your regular static directory and let Django's collectstatic handle this for you?

Do you need the JS build chain involved for some reason?

silviogutierrez avatar Apr 22 '24 00:04 silviogutierrez