lightbox.js icon indicating copy to clipboard operation
lightbox.js copied to clipboard

Feedback on media types and general integration

Open stevenkissack opened this issue 1 year ago • 4 comments

Hi!

I have just purchased and starting integrating your library as your demo on mobile seemed worth the money but it's a little slow to do because I don't think you've yet documented the video or youtube support, and also no mention of passing an images prop directly as far as I can see in the docs.

At this point I'm a little lost on best practice, do I copy from closed github issues, or follow the pages of example I see?

Some feedback below from my initial look at the code, hopefully this doesn't annoy you in any way, they're not demands!

  1. Documentation for the video, picture and youtube support
  2. Document passing the images prop instead of generating img elements (I want to support the new "original" param)
  3. Allow passing src instead of videoSrc for video elements - if picture support requires srcSet, why differ with video props not following spec name? also if the type is "video" and not "htmlVideo" could it be assumed they want the html video element?
  4. Support video.poster as posterSrc Mozilla - video
  5. Support src for YouTube as a complete URL override to support more flags without library support Youtube Docs
  6. Allow PDF or other browser supported content as iframe src? Can enforce an preset image dataURL in prop.thumbnail & prop.src as the link/html to iframe.

But honestly, right now I only need htmlVideo and image & they'll work once I create this 'images' prop :)

stevenkissack avatar Jul 02 '23 14:07 stevenkissack