onScreen icon indicating copy to clipboard operation
onScreen copied to clipboard

What about supporting Intersection Observer?

Open sergeymorkovkin opened this issue 5 years ago • 2 comments

It might be a good idea to rewrite plugin with support of Intersection Observer.

  1. It's got some support already - https://caniuse.com/#feat=intersectionobserver
  2. There is a polyfill - https://www.npmjs.com/package/intersection-observer

In short, it's more performant than current implementation.

sergeymorkovkin avatar Apr 05 '19 19:04 sergeymorkovkin

That is actually a nice idea. I'll look into it, thanks!

On Apr 5, 2019 at 4:30 PM, <Sergey Morkovkin (mailto:[email protected])> wrote:

It might be a good idea to rewrite plugin with support of Intersection Observer.

It's got some support already - https://caniuse.com/#feat=intersectionobserver

There is a polyfill - https://www.npmjs.com/package/intersection-observer

In short, it's more performant than current implementation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/silvestreh/onScreen/issues/64), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABFLG4Ssg6zerZymeAqHuAbwYOZbAp61ks5vd6RIgaJpZM4cflaJ).

silvestreh avatar Apr 05 '19 19:04 silvestreh

The thing is OnScreen has really great API. To me it makes perfect sense to keep up the pace. You may take a look at yall.js. They seem to have it done right.

sergeymorkovkin avatar Apr 05 '19 20:04 sergeymorkovkin