droppy icon indicating copy to clipboard operation
droppy copied to clipboard

[Request] thumbnails

Open andykais opened this issue 6 years ago • 9 comments

Hi, curious if thumbnails are in the works for videos, images, pdfs, etc. In a lot of cases, they can be generated using plain javascript video-thumbnail, image-thumbnail

andykais avatar Aug 26 '18 19:08 andykais

I don't think generating them client-side is a good idea as one would have to transfer full images which can result in a lot of bandwidth usage. They should be pre-generated asynchronously on the server, ideally in second process.

silverwind avatar Sep 02 '18 17:09 silverwind

Very nice work with droppy, silverwind!

What about thumbnails when posting link to Messenger, Discord etc? Would be a great to see.

akzkak avatar Dec 01 '18 18:12 akzkak

What about thumbnails when posting link to Messenger, Discord etc?

That's should already work because all data links are direct links. You may have to enable the linkExtensions option for shared image links to work in applications that only parse the URL.

silverwind avatar Dec 01 '18 19:12 silverwind

That's should already work because all data links are direct links. You may have to enable the linkExtensions option for shared image links to work in applications that only parse the URL.

Oh ye sorry. Do work for pictures both with and without linkExtensions, but not videos.

Maybe make it an option for those that do not care about the extra bandwidth usage.

akzkak avatar Dec 01 '18 20:12 akzkak

There is nothing I can do on my side except making sure the file is served with the correct mime type and the URL looks like it's a direct link. I guess most of these preview functions only work for a hardcoded list of pre-defined sites. If you observe any issues with the mime types droppy serves, I can do something about that (video mime types are often not well-defined).

silverwind avatar Dec 01 '18 21:12 silverwind

On second thought, I suspect some of these apps might be doing HEAD requests, I added support for them now. Try again in the next release.

silverwind avatar Dec 01 '18 21:12 silverwind

Cool. Did wonder how Google managed to do it on YouTube, but just guessed that was part of there video processing to optimize, save space and perhaps extract thumbnails etc etc.

Ill give the HEAD requests a go on next release. Thanks

akzkak avatar Dec 01 '18 21:12 akzkak

Updated to v10.0.11, but no luck, still no thumbnail. Did check "About" section to make sure it had updated. Tested on Messenger and Discord with and without linkExtensions enabled. Thanks for the try though.

akzkak avatar Dec 01 '18 22:12 akzkak

Then it's most likely Discord using a hardcoded list of domains I guess. Maybe I'll try later myself.

silverwind avatar Dec 02 '18 06:12 silverwind