silverwind
silverwind
So I'd suggest: - `favicon.svg` existing icon, unchanged - `favicon-success.svg` - `favicon-warning.svg` - `favicon-error.svg` The implementation could be backend-only and only for pull requests and possibly actions pages, e.g. deliver...
I'd rather have the icons named by intent instead of any concrete status because then they can be used in all places. They will be used in at least commit...
Will these names work on all action pages as well? Do workflows and jobs all use the same status names? I just want to ensure we can re-use these icons...
Oh and I think as long as we support PNG favicon fallbacks (I think they are still needed for Safari as per [this](https://caniuse.com/link-icon-svg)), we have to generate the PNGs. Should...
> Will these names work on all action pages as well? Do workflows and jobs all use the same status names? I just want to ensure we can re-use these...
Sounds good, but I would even go a step further and name it "status" instead of "commit status".
CI failures are unrelated and will be fixed with https://github.com/go-gitea/gitea/pull/36074.
> CI failures are unrelated and will be fixed with #36074. Actually no, not entirely unrelated. `go: -race requires cgo; enable cgo by setting CGO_ENABLED=1` is related.
I think we may just need to add `CGO_ENABLED = 1` after below line because the [race detector](https://go.dev/doc/articles/race_detector) depends on it and `RACE_ENABLED` should only ever be set during test...
Timeout after 50m seems odd as the db tests usually take only 30m, I've restarted the failing job, maybe it was a flake.