buz icon indicating copy to clipboard operation
buz copied to clipboard

Add ctx timeouts to all sinks

Open jakthom opened this issue 3 years ago • 1 comments

jakthom avatar Mar 11 '22 05:03 jakthom

Hey @jakthom, I'm thinking to take on that issue, if that's ok..?

Do you mean the user should add a timeout to the ctx (when calling the publish funcs)? if so then, inside each sink we'll handle the timeout gracefully ( if it's not already doing that on it's own like in Kafka's case)

orgr avatar Sep 05 '22 12:09 orgr

Oh man, @orgr I am so sorry about just seeing this! If you want to, by all means feel free.

I actually just merged some code that makes this much easier to implement.

Here's the best place to start: https://github.com/silverton-io/buz/blob/main/pkg/backend/backendutils/sink.go#L38

In terms of getting things up and running, make bootstrap after a git pull will get a sample config in place and buz spinning.

If you'd also like to get available backends up and running, there's a docker compose located here. After pulling buz-docs you can docker-compose -f devel/docker-compose.yml up to get the destinations spinning.

Again, so sorry for not seeing your comment sooner.

jakthom avatar Mar 03 '23 17:03 jakthom