silverstripe-cms icon indicating copy to clipboard operation
silverstripe-cms copied to clipboard

[2012-12-18] When actioning Un-publishing or Delete from Published site on a parent page - child pages aren't being marked as "Draft"

Open silverstripe-issues opened this issue 11 years ago • 7 comments

created by: @jbridson (jbridson) created at: 2012-12-18 original ticket: http://open.silverstripe.org/ticket/8139


When using the batch actions on /admin/pages/

  • select a page that has children and is published and has children that are published
  • select only the partent page using multiselect
  • Un-publish that page
  • Parent page gets marked as draft (lozenge) but children do not
  • If you go into the edit page for one of the children you will see it is in draft as the save and publish button is visible.
  • It is not until you refresh the page that the children get marked as Draft

The message that comes up says that only one page has been un-published but in actual fact the parent and all its children have been un-published - is this a bug also? Should this message inform the user that the children have also been un-published...

This is not a major bug but can be a little confusing as there is no lozenge on the child pages after batch actions have been performed.

silverstripe-issues avatar Apr 03 '13 20:04 silverstripe-issues

Update for SS4:

  • Tree is refreshed immediately, so child pages are marked as draft.
  • The “Are you sure” message only mentions the selected page(s) (doesn’t mention/warn about unpublishing children)
  • There is no confirmation message at all after the action has completed. Not sure if that’s a bug or by design...

kinglozzer avatar May 17 '17 09:05 kinglozzer

For me, the tree is not refreshed immediately so maybe that's a regression but it would make sense if it did.

Seems like we just need to have a better alert message with the default action being to make sure the action is done in a cascading way but as an edge-case wouldn't users need an alternative to be able to unpublish a page without it cascading down (can't think of a practical use)?

There is now a notification about the change in the top right corner :)

clarkepaul avatar Sep 25 '17 02:09 clarkepaul

Upgrading to impact/high as this could very frustrating to users if half their site was removed accidentally.

clarkepaul avatar Sep 25 '17 02:09 clarkepaul

Bug persists only when using the page actions, not when using batch actions on the tree.

tractorcow avatar Jan 23 '18 22:01 tractorcow

@newleeland can you look into this issue please

clarkepaul avatar Apr 15 '18 23:04 clarkepaul

Potential Designs

Unpublishing Parents https://invis.io/B9H47IR5VD4#/292213168_Pages___Unpublishing_Parent___Start

Archiving Parents https://invis.io/NEH47L4Z9YJ#/292213167_Pages___Archiving_Parent___Start

Potential AC's

  • All children page states need to reflect the state of the parent element. (sitetree icon, status tag, sitetree text)

newleeland avatar Apr 19 '18 00:04 newleeland

I'm moving this back to Icebox because I don't see how we can do this before refactoring the main CMS UI into React, without creating code we need to throw away again in a year.

chillu avatar Jul 29 '18 21:07 chillu