silverstripe-cms icon indicating copy to clipboard operation
silverstripe-cms copied to clipboard

[2012-05-23] Batch action "Go" gives no feedback it's working

Open silverstripe-issues opened this issue 12 years ago • 7 comments

created by: muzdowski created at: 2012-05-23 original ticket: http://open.silverstripe.org/ticket/7390


To reproduce:

  • go into the site-tree-only view
  • switch to multi-selection view with the radio
  • tick couple of pages (for example 5 of them)
  • invoke batch action
  • now guess: is it working or not? ;)

silverstripe-issues avatar Apr 03 '13 20:04 silverstripe-issues

comment by: @sminnee (sminnee) created at: 2012-06-14


There's a completion feedback but not "whirling" icon to show it's processing. We should do this but it's not in the RC1 milestone anymore.

silverstripe-issues avatar Apr 03 '13 20:04 silverstripe-issues

comment by: @chillu (ischommer) created at: 2012-09-19


Container card: http://open.silverstripe.org/ticket/7878

silverstripe-issues avatar Apr 03 '13 20:04 silverstripe-issues

+1 (ss 3.3.1) When publishing a number of pages with batch actions it's taking a long time to finish, and users don't have a clue if it's still working, hangs or finished

Friksel avatar Apr 16 '16 10:04 Friksel

4.x still has this issue. Batch actions has no loading indicator.

tractorcow avatar May 16 '17 04:05 tractorcow

In silverstripe-admin:

diff --git a/client/src/legacy/LeftAndMain.BatchActions.js b/client/src/legacy/LeftAndMain.BatchActions.js
index 579033d..8d8de36 100644
--- a/client/src/legacy/LeftAndMain.BatchActions.js
+++ b/client/src/legacy/LeftAndMain.BatchActions.js
@@ -280,6 +280,7 @@ $.entwine('ss.tree', function($){
       tree.find('li').removeClass('failed');

       var button = this.find(':submit:first');
+      jQuery('.cms-content').addClass('loading');
       button.addClass('loading');

       jQuery.ajax({
@@ -288,6 +289,7 @@ $.entwine('ss.tree', function($){
         type: 'POST',
         data: this.serializeArray(),
         complete: function(xmlhttp, status) {
+          jQuery('.cms-content').removeClass('loading');
           button.removeClass('loading');

           // Refresh the tree.

mikenz avatar Mar 11 '18 23:03 mikenz

Fixed with https://github.com/silverstripe/silverstripe-framework/pull/8063 in 3.5, will be merged up and probably released in 3.7.1

robbieaverill avatar Jun 12 '18 23:06 robbieaverill

Oops, still affects v4 - will re-label and leave open

robbieaverill avatar Jun 12 '18 23:06 robbieaverill