silverstripe-cms icon indicating copy to clipboard operation
silverstripe-cms copied to clipboard

Published 20 hours ago • verified publisher icon silverstripe

Refactor CMSMain and its subclasses

Open sabina-talipova opened this issue 1 year ago • 0 comments

Description

See: https://github.com/silverstripe/silverstripe-cms/blob/58a2d5817398cb41cb983e609c879aab73c57f28/code/Controllers/CMSMain.php#L83

This "TODO" comment was created in 2016. We need to investigate this matter and assess its current relevance.

CMSMain and its subclasses are a mess. We should look at refactoring these, preferably in a generic way that provides a more generic "TreeModelAdmin" style class. The CMSMain could just be a subclass of that. We should ideally not need a sub CMSPageAddController, CMSPageEditController, CMSPageSettingsController, CMSPagesontroller, etc.

sabina-talipova avatar Oct 11 '23 23:10 sabina-talipova