silverstripe-cms icon indicating copy to clipboard operation
silverstripe-cms copied to clipboard

PATCH: cater for edge cases in CM Edit Link

Open sunnysideup opened this issue 2 years ago • 2 comments

image

sunnysideup avatar Oct 02 '22 19:10 sunnysideup

This is not a good pull request. I was thinking about it again and it should allow for other extensions to come through if required. Maybe like this:

    /**
     * Generates a link to edit this page in the CMS.
     *
     * @return string
     */
    public function CMSEditLink()
        $link = CMSEditLinkExtension::get_link($this);
        $this->extend('CMSEditLinkUpdate', $link);
        return $link;
    }

sunnysideup avatar Oct 02 '22 20:10 sunnysideup

Can you please create an issue for this PR which explains what the problem is that you're trying to solve? The screenshot doesn't explain what you're solving, it just shows an error without providing any reproduction steps or an explanation of what's causing the error to occur.

After that, please update this PR - you've indicated that it's "not a good pull request" so please make it good ;p

GuySartorelli avatar Oct 02 '22 23:10 GuySartorelli

Closing as the requested changes were not made.

GuySartorelli avatar Jan 20 '23 02:01 GuySartorelli