silverstripe-cms icon indicating copy to clipboard operation
silverstripe-cms copied to clipboard

Add page UI options shouldn't be set back , padding missing on smaller viewports

Open clarkepaul opened this issue 6 years ago • 4 comments

The page types within the add page UI shouldn't have a negative margin on the left, on smaller viewports these page options touch the CMS menu. pasted_image_28_01_19__12_59_pm

CSS to remove: image

clarkepaul avatar Jan 28 '19 00:01 clarkepaul

Just had a quick look. If the left/right margin can remove, the step 2 option get misaligned relative to the step 1.

image

maxime-rainville avatar Jan 31 '19 07:01 maxime-rainville

Yeah I saw that, I thought it was the lesser of two evils. Ideally we would remove the padding around page selection of pages and revert back to the default checkbox style.

A side note is that we would eventually redesign this experience to make adding pages possible directly from the site tree rather than having to navigate away (similar to the add block functionality of Elemental), although that will be a way off development wise.

clarkepaul avatar Feb 03 '19 22:02 clarkepaul

Would that use the same design pattern as elemental? Using PopoverOptionSet?

ScopeyNZ avatar Feb 04 '19 07:02 ScopeyNZ

Probably @ScopeyNZ , your favourite component :)

clarkepaul avatar Feb 04 '19 22:02 clarkepaul