silverstripe-admin
silverstripe-admin copied to clipboard
"Add" button is too small for loading indicator when adding a page to a campaign
Version: 1.x-dev (1.4.x-dev)
When adding a page to a campaign, the "Add" button is not wide enough to contain the loading indicator. It squashes together when you click on it.
Changing "Add" to "Add to campaign", or anything longer, fixes the issue.
Pull requests
- [ ] https://github.com/silverstripe/silverstripe-admin/pull/993
@jamesrford suggested applying a min-width of e.g. 120px to any button that is in a loading state
70px min-width seems like the minimum required to keep the loading indicator on a single line, but that also means the button grows slightly in size when you click it.
Still an issue in 4.4.3
Just came across this too... Here's a GIF of current behaviour:
Still an issue in 4.5-rc1. Got a PR https://github.com/silverstripe/silverstripe-admin/pull/993