silverstripe-admin icon indicating copy to clipboard operation
silverstripe-admin copied to clipboard

Modules cannot access the default Bootstrap variables—only our custom variables

Open clarkepaul opened this issue 6 years ago • 1 comments

Currently we comment out the entire bootstrap variables within silverstripe-admin with the exception of variables which have been customised, this means modules only have access to the modified variables and not the default un-modified variables (unless each module had Bootstrap included in the module—and same version). This was done so we can moderate what has been customised and what hasn't.

I'm proposing that we uncomment the whole stylesheet "bootstrap-variables" so that it can be used by other modules, we could possibly put a note next to each item which has been customised but this isn't essential.

cc @lukereative @robbieaverill

clarkepaul avatar Apr 20 '18 05:04 clarkepaul

Yes, please include a full variable sheet in the admin module. If we only change the values of variables then it'll continue to be easy to diff it against the default Bootstrap sheet to find out what we've changed.

robbieaverill avatar Apr 20 '18 05:04 robbieaverill