silverstripe-admin icon indicating copy to clipboard operation
silverstripe-admin copied to clipboard

Published 20 hours ago • verified publisher icon silverstripe

LeftAndMain.Panel.js - fix redraw order in togglePanel

Open sabina-talipova opened this issue 1 year ago • 2 comments

Description

Fix redraw order (inner to outer) in togglePanel, and re-enable silent flag to avoid multiple expensive redraws on a single load. See: https://github.com/silverstripe/silverstripe-admin/blob/0f18b3d40972d421f2756b6b90b55283dfc6fea2/client/src/legacy/LeftAndMain.Panel.js#L158-L159

sabina-talipova avatar Oct 16 '23 23:10 sabina-talipova

@sabina-talipova At first glance this sounds good (particularly "avoid multiple expensive redraws on a single load") - but I'm not sure what this issue is actually asking us to implment. If you understand the context of the comment, can you please flesh out the issue a bit more with some context and additional information? Otherwise, we should probably close it.

GuySartorelli avatar Oct 25 '23 00:10 GuySartorelli

Actually, I don't quite understand requirements of this TODO, but it seems to me that we should investigate possible issue mentioned in this comment. I would prefer to leave this ticket for a while and learn what happens, but don't spend too much time on it.

sabina-talipova avatar Oct 26 '23 19:10 sabina-talipova