silverstripe-admin icon indicating copy to clipboard operation
silverstripe-admin copied to clipboard

array is an invalid proptype for aria-label

Open NightJar opened this issue 2 years ago • 2 comments

https://github.com/silverstripe/silverstripe-admin/blob/be31300d49ec28520e9ff3aed2ccf4b35efae759/client/src/components/Button/Button.js#L10

Warning: Failed prop type: Invalid prop aria-label of type array supplied to Button, expected string. checkPropTypes.js:20

The children prop is an array of all children. The button element's content model accepts all phrasing content except interactive content. The children prop could rightfully contain components/elements in this context.

NightJar avatar Nov 12 '22 11:11 NightJar

Is this actually causing any problems? If so can you please describe what problems this is causing?

GuySartorelli avatar Nov 22 '22 03:11 GuySartorelli

Errors in the console whenever this widget is used.

NightJar avatar Nov 22 '22 08:11 NightJar