Matija Šuklje

Results 211 comments of Matija Šuklje

For the vast majority of the files this should be fine as is. The only question here would be if we should also add `fish-shell contributors` as copyright holders to...

> I think it's a good idea to clarify our licenses, and having a machine-readable format is great, but I would _much_ prefer being able to leave the license in...

> > src/wgetopt.* seems to be originally under LGPL-2.0-or-later, someone should double-check that. > > Pretty sure it's nicked from old glibc. Then probably the most correct version would be...

Thanks for looking into this. I half-expected this PR to be just shown the door right away, as it introduces changes that have no purely functional gain, just on a...

Thanks for dropping by and shedding some light on the matter, @siteshwar :) @siteshwar, thanks for popping by and clarifying :) > Right. It was me who had done the...

I made the changes to the 3rd party software licensing & copyright info as discussed here. In addition, I went ahead and added the `fish-shell contributors` copyright statement to all...

> A top-level COPYING file is obviously the default license for any file without the header, does REUSE not recognize this? No, because in practice that often turns out not...

> > I’m surprised that two extra lines that can be very simply put into a very simple [git hook](https://www.git-scm.com/docs/githooks) like this, should be a big overhead: > > And...

> > If I understand git hooks correctly, if you git add e.g. .git/hooks/reuse_header.sh to the repo, it would work automatically, no? > > I am _reasonably_ sure you can't...

@krobelus, I did not know, but did wonder about security of hooks, so that makes perfect sense. I’ll keep it in mind, thanks!