monkey365 icon indicating copy to clipboard operation
monkey365 copied to clipboard

[Bug]: Monkey365 is not handling duplicate entries in Analysis parameter

Open silverhack opened this issue 1 year ago • 1 comments

What happened?
Duplicate values in Analysis should raise some kind of warning. This would help prevent mistakes when working with larger tenants and complex configs.

How to reproduce it
Steps to reproduce the behavior:


$param = @{
    Instance = 'Microsoft365';
    Analysis = @("SharePointOnline","Microsoft365","ExchangeOnline","SharePointOnline","Purview","MicrosoftTeams");
    PromptBehavior = 'SelectAccount';
    IncludeEntraID = $true;
    ExportTo = @("CSV","JSON","HTML");
}
Invoke-Monkey365 @param

The above command will be executed without throwing any error (or warning).

Expected behavior
Duplicate values in Analysis should raise some kind of warning or throw an error.

From where are you running Monkey365?
Please, complete the following information:

  • Resource: [Docker container, workstation) all
  • OS: [e.g. Windows, Linux, etc. ] all
  • PowerShell Version [$PsVersionTable]: all versions
  • Monkey365 Version: Monkey365 v0.91.2-beta (dev)

silverhack avatar Feb 27 '24 11:02 silverhack

Fix on dev branch.

Cheers,

silverhack avatar Feb 27 '24 11:02 silverhack

This is now updated in main release.

Cheers,

silverhack avatar Jun 10 '24 17:06 silverhack