Results 225 comments of Sean Silva

Hey MHLO folks, before you add too many new ops, can you please plug in the MHLO backend into the end-to-end tests in our CI? More info here: https://github.com/llvm/torch-mlir/pull/1025#issuecomment-1178465875 I'm...

LGTM! Please make sure to squash all your commits before merging.

This experiment is under way and quite successful in https://github.com/llvm/torch-mlir/issues/1178 We can close this issue for now and reopen / create a new issue when we need to course-correct.

@asaadaldien was also interested in bazel, though I don't know if the exact use case is the same. I am okay with following LLVM precedent here of having it unsupported...

> @garymm yes, you can write bazel rules for each cmake library easily with very little manual effort one caveat there is a small header circular dependency between `Troch\Transforms\* &&...

> There is another small caveat here, bazel can't have a top level directory [external](https://github.com/bazelbuild/bazel/issues/4508), it works on my case because torch_mlir is dependency and not the main repo but...

It is supported now: https://github.com/llvm/torch-mlir/blob/main/docs/development.md#bazel-build

My intuition is that this model should be traceable. I looked through the code and I didn't find any examples of a non-traceable construct. Can you please link to any...

Those are just hyperparameters. Hyperparameters do not change during program execution and are expected to require different traced/scripted program captures per set of hyperparameters.