RPi_Cam_Web_Interface icon indicating copy to clipboard operation
RPi_Cam_Web_Interface copied to clipboard

Update index.php

Open ras07 opened this issue 5 years ago • 3 comments

was missing $ before the variable buttonCount on line 49. This didn't cause a problem (other than giving the user infinite buttons) but it results in the following message in the Apache error log:

Use of undefined constant buttonCount - assumed 'buttonCount' (this will throw an Error in a future version of PHP) in /var/www/http/index.php on line 49

ras07 avatar Feb 18 '20 09:02 ras07

Thanks. I have corrected this.

roberttidey avatar Feb 18 '20 11:02 roberttidey

This code logic that limits the number of buttons to 6 is overly strict, in my opinion. In fact, I use 10 buttons, which used to work fine before this typo was fixed. It should really parse the "width:10%" attributes for each button and instead check that the total doesn't exceed 100%.

hogwell avatar Jun 13 '20 23:06 hogwell

I have upped the maximum user button count to 12. No specific check on widths. I think they will wrap if width is exceeded.

roberttidey avatar Jun 14 '20 11:06 roberttidey