Better USFM parsing error visibility
Codecov Report
Attention: Patch coverage is 60.97561% with 48 lines in your changes are missing coverage. Please review.
Project coverage is 67.19%. Comparing base (
f4b27e5) to head (77d072e).
Additional details and impacted files
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 67.25% 67.19% -0.06%
==========================================
Files 441 442 +1
Lines 34940 35009 +69
Branches 4686 4691 +5
==========================================
+ Hits 23498 23524 +26
- Misses 10356 10399 +43
Partials 1086 1086
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We also have a request to add which corpus it's from.
src/SIL.Machine/Corpora/UsfmFileText.cs line 43 at r5 (raw file):
.SetValue(e, $"{_fileName}: {e.Message}"); throw e; }
@ddaspit - what do you think about spitting out the filename like this?
I don't think it is necessary to output the filename. The verse ref should be sufficient to tell you what file in a project is having the issue.
But if there are two sources and one target scripture, they don't know which one to look at. The ID of the paratext zip file should tell them more.
That is a good point. I will look at adding that. We might need to update the gRPC API to pass the file id.
There's been a lot of churn on this PR, so I submitted a separate PR that throws an exception with all of the information we need. I'm going to close this PR.