libpalaso icon indicating copy to clipboard operation
libpalaso copied to clipboard

+semver:major Made ParseDateTimePermissivelyWithException into an extension method

Open tombogle opened this issue 8 months ago • 1 comments

This is kind of related to SP-2356, though it's not yet clear whether any actual logic changes will be needed in these date-handling methods.

Added test cases for ToISO8601TimeFormatWithUTCString and some unit tests for Made ParseDateTimePermissivelyWithException


This change is Reviewable

tombogle avatar Apr 15 '25 18:04 tombogle

Palaso Tests

     4 files  ±  0       4 suites  ±0   10m 44s :stopwatch: - 9m 11s  4 973 tests + 38   4 743 :white_check_mark: + 37  230 :zzz: +1  0 :x: ±0  16 171 runs  +114  15 479 :white_check_mark: +109  692 :zzz: +5  0 :x: ±0 

Results for commit 2ec43276. ± Comparison against base commit 73469af5.

This pull request removes 4 and adds 42 tests. Note that renamed tests count towards both.
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateExecutable_NonexistingFile
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateExecutable_NonexistingFileThrows
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateInProgramFiles_DeepSearch_FindsFileInSubdir
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateInProgramFiles_SendInValidSubFolder_DoesNotThrow
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("d-M-yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("d/M/yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("dd MMM yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("dd/MM/yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureUSDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("D")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureUSDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("M-d-yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureUSDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("M/d/yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureUSDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("MM-dd-yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureUSDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("MM/dd/yyyy")
SIL.Tests.Extensions.DateTimeExtensionTests ‑ ParseDateTimePermissivelyWithException_NearFutureUSDatesWithThaiBuddhistCalendar_ReturnsDateWithPastYear("d")
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateInProgramFiles_DeepSearch_FindsFileInSubdir
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateInProgramFiles_DeepSearch_FindsFileInSubDir
This pull request skips 1 test.
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateInProgramFiles_SendValidProgramDeepSearch_ReturnsProgramPath

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 15 '25 18:04 github-actions[bot]