libpalaso icon indicating copy to clipboard operation
libpalaso copied to clipboard

[SIL.Lift] Clean up LiftParser

Open imnasnainaec opened this issue 9 months ago • 1 comments

Cleanup started during #1414, but no changes to this file were necessary for that pr.


This change is Reviewable

imnasnainaec avatar Mar 28 '25 15:03 imnasnainaec

Palaso Tests

     4 files  ±0       4 suites  ±0   18m 48s :stopwatch: +48s  4 935 tests ±0   4 706 :white_check_mark: ±0  229 :zzz: ±0  0 :x: ±0  16 057 runs  ±0  15 370 :white_check_mark: ±0  687 :zzz: ±0  0 :x: ±0 

Results for commit 779af45d. ± Comparison against base commit 20f7c17e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 28 '25 15:03 github-actions[bot]

SIL.Lift/Parsing/LiftParser.cs line 624 at r2 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

Ah, I guess somebody's script could be relying on particular progress messages. Reverted.

I don't see anything outside SIL.Windows.Forms* or TestApps/ with using L10NSharp;, so I'm not inclined to start localization in SIL.Lift just for this file.

Right. This would require some analysis. I'm not sure how these progress messages are used. There are strategies for localization in contexts where we can't directly depend on L10nSharp, but first we'd need to see if it actually makes sense.

tombogle avatar May 13 '25 12:05 tombogle