libpalaso icon indicating copy to clipboard operation
libpalaso copied to clipboard

Renamed project to SIL.Windows.Forms.Archiving

Open josephmyers opened this issue 10 months ago • 5 comments

This change is Reviewable

josephmyers avatar Apr 25 '24 08:04 josephmyers

Palaso.sln line 30 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

Now I'm wondering if we should actually be trying to split this stuff into Forms vs. non-Forms DLLs. None of the unit tests depend on WinForms, so all the classes they are testing could be in a non-Forms dependent DLL. I'm not sure if they do anything useful enough on their own to warrant this though.

Looking at the code, the ArchivingDlg classes (abstract base and two concrete implementations) are the only things that really need to depend on WinForms. The models do, but only minimally and in a way they really shouldn't. If we were to fix those design issues, then those models could be used to back a non WinForms implementation.

tombogle avatar Apr 25 '24 12:04 tombogle

@tombogle, any chance we'll see progress here this week or next?

josephmyers avatar May 09 '24 05:05 josephmyers

Not sure when I'll be able to get to this.

tombogle avatar May 13 '24 13:05 tombogle

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

josephmyers avatar May 20 '24 08:05 josephmyers

I discovered today that SIL.Media is a WinForms project. So a bit more to come on this

@josephmyers we can rename SIL.Media in a separate PR.

megahirt avatar May 20 '24 13:05 megahirt