Support custom semantic domains ending in 0
Codecov Report
Attention: Patch coverage is 62.45211% with 98 lines in your changes missing coverage. Please review.
Project coverage is 74.82%. Comparing base (
683ebac) to head (2727088).
Additional details and impacted files
@@ Coverage Diff @@
## master #3081 +/- ##
==========================================
- Coverage 84.16% 74.82% -9.34%
==========================================
Files 47 277 +230
Lines 4925 10622 +5697
Branches 587 1270 +683
==========================================
+ Hits 4145 7948 +3803
- Misses 637 2310 +1673
- Partials 143 364 +221
| Flag | Coverage Δ | |
|---|---|---|
| backend | 83.84% <69.38%> (-0.32%) |
:arrow_down: |
| frontend | 66.83% <58.28%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Backend/Services/LiftService.cs line 661 at r2 (raw file):
{ private readonly string _projectId; private readonly List<SemanticDomainFull> _semDoms = new();
I think this variable needs renaming to capture its use.
src/components/TreeView/tests/utilities.test.ts line 59 at r2 (raw file):
).not.toBeUndefined(); expect(mockGetSemanticDomainTreeNode).toHaveBeenCalledTimes(1);
This feels like it is getting too far past the unit, into the specifics of the implementation. Are the types of calls made to find the parent an implementation detail, or critical to the methods correct behavior?