TheCombine icon indicating copy to clipboard operation
TheCombine copied to clipboard

Support custom semantic domains ending in 0

Open imnasnainaec opened this issue 1 year ago • 1 comments

Resolves #741


This change is Reviewable

imnasnainaec avatar Apr 30 '24 16:04 imnasnainaec

Codecov Report

Attention: Patch coverage is 62.45211% with 98 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (683ebac) to head (2727088).

Files Patch % Lines
src/components/ProjectSettings/ProjectDomains.tsx 50.96% 50 Missing and 1 partial :warning:
Backend/Services/LiftService.cs 52.94% 21 Missing and 3 partials :warning:
...rc/components/ProjectSettings/ProjectLanguages.tsx 50.00% 7 Missing :warning:
Backend/Controllers/LiftController.cs 28.57% 5 Missing :warning:
src/components/DataEntry/index.tsx 44.44% 3 Missing and 2 partials :warning:
src/components/TreeView/utilities.ts 88.46% 1 Missing and 2 partials :warning:
Backend/Models/SemanticDomain.cs 97.43% 1 Missing :warning:
src/components/TreeView/Redux/TreeViewActions.ts 80.00% 0 Missing and 1 partial :warning:
src/components/TreeView/index.tsx 66.66% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3081      +/-   ##
==========================================
- Coverage   84.16%   74.82%   -9.34%     
==========================================
  Files          47      277     +230     
  Lines        4925    10622    +5697     
  Branches      587     1270     +683     
==========================================
+ Hits         4145     7948    +3803     
- Misses        637     2310    +1673     
- Partials      143      364     +221     
Flag Coverage Δ
backend 83.84% <69.38%> (-0.32%) :arrow_down:
frontend 66.83% <58.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 16:04 codecov[bot]

Backend/Services/LiftService.cs line 661 at r2 (raw file):

        {
            private readonly string _projectId;
            private readonly List<SemanticDomainFull> _semDoms = new();

I think this variable needs renaming to capture its use.

jasonleenaylor avatar Jul 01 '24 16:07 jasonleenaylor

src/components/TreeView/tests/utilities.test.ts line 59 at r2 (raw file):

    ).not.toBeUndefined();

    expect(mockGetSemanticDomainTreeNode).toHaveBeenCalledTimes(1);

This feels like it is getting too far past the unit, into the specifics of the implementation. Are the types of calls made to find the parent an implementation detail, or critical to the methods correct behavior?

jasonleenaylor avatar Jul 01 '24 17:07 jasonleenaylor