ecs-deploy icon indicating copy to clipboard operation
ecs-deploy copied to clipboard

New PR incorporating #177 changes but resolving conflict

Open fillup opened this issue 4 years ago • 3 comments

I'm not able to merge #177 due to a conflict, so this new branch has the conflict resolved and changes from @awinder merged in.

@jybaek can you try this out and see if it works for your situation?

fillup avatar Apr 29 '21 21:04 fillup

@awinder and @jybaek there was a conflict in the original PR so I worked through that, then with some further testing found the polling for completion had changed so I needed to refactor some of that as well. Currently deployments are timing out for me due to the new checking of deployment status and count, so that needs more testing and updates before this can be merged.

fillup avatar Apr 29 '21 22:04 fillup

@fillup cooool, You saved me from hell. :-)

If there is an option to request update-service and exit immediately, this process is not necessary. how about?

jybaek avatar Apr 30 '21 00:04 jybaek

very cool! I would try this out to confirm for you that the behavior worked for the use-case but unfortunately I'm not in a team that's set up using this workflow anymore. but thanks for dusting it off & glad/hopeful it was useful!

awinder avatar May 19 '21 20:05 awinder

Given the age of this PR and the conflicts, I'm going to close it out. If you still want to pursue this, please submit a new PR based on the latest code.

devon-sil avatar Jan 25 '24 14:01 devon-sil