ecs-deploy icon indicating copy to clipboard operation
ecs-deploy copied to clipboard

tag only: applying to main image only (first one)

Open jfranzoi opened this issue 3 years ago • 4 comments

Migrated --tag-only to support the scenario of the image tag being updated to the main container definition only, not every one. At the moment, main means being the first one.

Of course, this is an opinionated choice, and I'm proposing to migrate to this behaviour instead of adding complexity with another switch to the command line. Does it make any sense? The existing test case I think was also showing this being the original intent (having redis:latest image not get update I mean, seems like an improvement).

Added support for test execution on Mac development as well.

jfranzoi avatar Apr 05 '21 14:04 jfranzoi

@fillup with no rush, just give me some feedback on the overall proposal! Thank you 👍

jfranzoi avatar Apr 05 '21 17:04 jfranzoi

hello @fillup, just wondering if you had the chance to have a look at this. thank you!

jfranzoi avatar Apr 12 '21 10:04 jfranzoi

Hello @fillup, and almost happy new year 😂

In the meanwhile, I transferred ownership of the fork and this PR to my company account. Since we're effectively using it in production since a while, I'm asking if there's any chance to be merged.

Anyway, just wanted to share we just open-sourced our internal CI/CD tool for ECS, intended as a lightweight wrapper of your great ecs-deploy. See here for details.

Thank you 👍

jfranzoi-gucci avatar Dec 31 '21 15:12 jfranzoi-gucci

Hi @jfranzoi-gucci, and thanks for your contribution. @fillup has handed off responsibility for our ecs-deploy script to me, but I still need to familiarize myself with it more before I can an informed decision about your suggestion.

In general, though, we are considering ecs-deploy to be feature-complete (except for bugs or new AWS CLI features), so it's probably best for the time being for you to continue using your fork of ecs-deploy.

forevermatt avatar Jan 03 '22 15:01 forevermatt

Given the age of this PR and that it has conflicts, I'm going to close it out. If you still want to pursue this, please submit a new PR based on the latest code.

devon-sil avatar Jan 23 '24 16:01 devon-sil