ecs-deploy icon indicating copy to clipboard operation
ecs-deploy copied to clipboard

Add memory to conditional options for all launch types

Open ginman86 opened this issue 4 years ago • 3 comments

This PR adds the memory parameter to the conditional options. This parameter can be set in either fargate or ec2 launch types and should always be included in the copied task definition if it is present.

ginman86 avatar Aug 26 '20 17:08 ginman86

This parameter needs to be included in order for it to be set when automatically generating new task-definition versions. Otherwise it will revert to the default, breaking the deploy for any task definitions that need specific memory settings.

ginman86 avatar Sep 24 '20 20:09 ginman86

@ginman86 this change looks pretty simple, but it's throwing errors for me:

Parameter validation failed:
Invalid type for parameter memory, value: None, type: <class 'NoneType'>, valid types: <class 'str'>

What version of awscli are you using for that option? I'm not on the latest, but I am on the latest for Ubuntu 20.04:

> aws --version
aws-cli/1.18.69 Python/3.8.5 Linux/5.8.0-44-generic botocore/1.16.19

fillup avatar Feb 26 '21 15:02 fillup

Bump. Need this fix. Getting An error occurred (ClientException) when calling the RegisterTaskDefinition operation: Invalid setting for container 'my-container'. At least one of 'memory' or 'memoryReservation' must be specified every time deploying to ECS's EC2 instance.

a0s avatar Jul 29 '21 10:07 a0s

Given the age of this PR and that it has conflicts, I'm going to close it out. If you still want to pursue this, please submit a new PR based on the latest code.

devon-sil avatar Jan 23 '24 16:01 devon-sil