ecs-deploy icon indicating copy to clipboard operation
ecs-deploy copied to clipboard
verified publisher icon silinternational

Allow underscores in repository names.

Open gfl-chris opened this issue 5 years ago • 5 comments

Repository names may contain underscores, but they can't start with one.

gfl-chris avatar Jan 28 '20 16:01 gfl-chris

@fillup Can we get this merged? :P

gfl-chris avatar Jan 29 '20 15:01 gfl-chris

@fillup poke

gfl-chris avatar Feb 03 '20 17:02 gfl-chris

Hey @fillup, would you mind merging this?

gfl-chris avatar Feb 25 '20 15:02 gfl-chris

Ping.

gfl-chris avatar Mar 31 '20 16:03 gfl-chris

@gfl-chris are you still interested in this change getting through? Looks like I had a question back in August but haven't heard back.

fillup avatar Feb 26 '21 15:02 fillup

@briskt This is a simple PR, even though the tests weren't written. Would you review this, merge it if it looks good, and then go ahead and add in the tests fillup mentions?

devon-sil avatar Jan 04 '24 14:01 devon-sil