onediff icon indicating copy to clipboard operation
onediff copied to clipboard

compared the output results of acceleration schemes from both the deepcache and onediff versions

Open onefish51 opened this issue 10 months ago • 3 comments

Describe the bug

I compared the output results of acceleration schemes from both the deepcache and onediff versions, and found that typically, the deepcache version produces lower quality images, with a greater tendency to exhibit malformed hands and legs, as well as peculiar color blocks displaying abrupt transitions. These issues are particularly pronounced when the generated images have an aspect ratio other than 1:1, specifically in the case of a 9:21 ratio.

Your environment

Ubuntu 20.04.6 LTS

OneDiff git commit id

Building wheels for collected packages: onediff
  Building editable for onediff (pyproject.toml) ... done
  Created wheel for onediff: filename=onediff-0.13.0.dev1-0.editable-py3-none-any.whl size=5365 sha256=672b46d89c4cde6bd23e818a3694e9c3f8e9bc3593beb1f7c1bc7671638697c2
  Stored in directory: /tmp/pip-ephem-wheel-cache-sup957_q/wheels/01/30/ea/6d3fee7612e410bc7ccd7c32f1cd929ab8930caa0fec1c256b
Successfully built onediff
Installing collected packages: onediff
  Attempting uninstall: onediff
    Found existing installation: onediff 0.13.0.dev1
    Uninstalling onediff-0.13.0.dev1:
      Successfully uninstalled onediff-0.13.0.dev1
Successfully installed onediff-0.13.0.dev1

OneFlow version info

libibverbs not available, ibv_fork_init skipped
Ignoring PCI device with non-16bit domain.
Pass --enable-32bits-pci-domain to configure to support such devices
(warning: it would break the library ABI, don't enable unless really needed).
path: ['/opt/conda/lib/python3.10/site-packages/oneflow']
version: 0.9.1.dev20240125+cu121
git_commit: 6458a12
cmake_build_type: Release
rdma: True
mlir: True
enterprise: False

How To Reproduce

workflow_compare.json

The output results of acceleration schemes from both the deepcache and onediff versions

image image image image image image image image

add several examples of anomalies for the deepcache

6121712480753_ pic@w=200h=100 6101712480750_ pic promeai_00017_ 6111712480753_ pic promeai_00018_

onefish51 avatar Apr 07 '24 09:04 onefish51

Thanks @onefish51

How many steps are you using? Seems that deepcache is not woking well with little steps( less than 30)

strint avatar Apr 15 '24 15:04 strint

@onefish51 Deepcache is a lossy algorithm. If you want to be close to the original algorithm, you can adjust cache_interval to a smaller value, or adjust cache_layer_id and cache_block_id to larger values.

clackhan avatar Apr 16 '24 01:04 clackhan

Thanks @onefish51

How many steps are you using? Seems that deepcache is not woking well with little steps( less than 30)

as the workflow shown "20 steps" workflow_compare.json

onefish51 avatar Apr 16 '24 09:04 onefish51