CloudExplorer2 icon indicating copy to clipboard operation
CloudExplorer2 copied to clipboard

Linter warnings

Open lexoyo opened this issue 7 years ago • 4 comments

We should cleanup the code to remove linter warnings, i.e. do npm run lint and fix the warnings

lexoyo avatar Jan 31 '18 18:01 lexoyo

Good idea but most of the warnings are not trivial :

  • no-console, meaning we need to choose a logger strategy
  • no-alert, basically the same thing
  • class-method-use-this, meaning we need to refactor some classes to use static methods as much as possible

So this will be needed soon, but not sure it's a good first issue 😉

JbIPS avatar Jan 31 '18 19:01 JbIPS

Hello Jb ! Maybe could I just delete the console.log ? Alex told me it should be enough to fix this issue.

louisauve avatar Feb 01 '18 08:02 louisauve

Hello @louisauve and welcome in this project! If @lexoyo said they're not needed, remove them 😃

JbIPS avatar Feb 04 '18 00:02 JbIPS

I reopen this issues as there are still warnings and even a few errors, am I right?

lexoyo avatar Oct 15 '18 15:10 lexoyo