reactgrid icon indicating copy to clipboard operation
reactgrid copied to clipboard

Fixed cell position on scroll while in edit mode

Open tytevaipie opened this issue 1 year ago • 8 comments

Describe the bug When editing mode is invoked for a cell and scrolling is performed simultaneously, cell remains in a fixed position.

Expected behavior Editable cell position should remain relative to the grid.

Screenshots or gifs reactgrid_bug

Your environment details

  • Device: Desktop
  • Browser: Chrome, Firefox, Edge

tytevaipie avatar Sep 04 '23 11:09 tytevaipie

This is the expected behavior. Do you think it should be locked to grid container rather than body?

DLowHP avatar Sep 06 '23 07:09 DLowHP

This is the expected behavior. Do you think it should be locked to grid container rather than body? Yes @DLowHP It should be locked to grid container as it is looking ugly floating textbox. Let us know if any workaround is there for this.

pawaningale93 avatar Sep 07 '23 06:09 pawaningale93

This is the expected behavior. Do you think it should be locked to grid container rather than body?

Yes, the editable cell should stay within the grid component as it makes no sense for it to float over the other unrelated components on scroll.

tytevaipie avatar Sep 07 '23 06:09 tytevaipie

I had to reopen this issue as the solution I pushed does not work on sticky/frozen cells. I totally forgot to check it before merging the PR - my bad, sorry! Unfortunately after spending significant amount of time searching for a better solution I must sadly say that this won't be fixed in the current RG version as it would require too much changes potentially introducing new issues. Nevertheless I think this could be introduced in the upcoming v5 🤔

DLowHP avatar Nov 02 '23 13:11 DLowHP

I think both scenarios can exist, and it is recommended that users customize them through configuration.

  1. Cells do not scroll along with the page, have been in the window, do not disappear, allowing users to focus on editing.
  2. As the cell scrolls through the page, it can not cover other modules, which can make the component complete

qiufeihong2018 avatar Dec 07 '23 07:12 qiufeihong2018

Thank you, Bro Can I combine columns and lines and display excel like input cells to be more beautiful?

Vào Th 5, 7 thg 12, 2023 vào lúc 14:24 大卫 @.***> đã viết:

I think both scenarios can exist, and it is recommended that users customize them through configuration.

  1. Cells do not scroll along with the page, have been in the window, do not disappear, allowing users to focus on editing.
  2. As the cell scrolls through the page, it can not cover other modules, which can make the component complete

— Reply to this email directly, view it on GitHub https://github.com/silevis/reactgrid/issues/221#issuecomment-1844805823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZOJOBQEBYW4SY3V44HODATYIFVJ7AVCNFSM6AAAAAA4KHWDFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBUHAYDKOBSGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lamdev03 avatar Dec 07 '23 07:12 lamdev03

@lamntph28897 This already seems to be an issue https://github.com/silevis/reactgrid/issues/88

qiufeihong2018 avatar Dec 07 '23 09:12 qiufeihong2018

@DLowHP That's unfortunate, We really thought we finally found the perfect library for our project but everyone said no to this and there's no easy way to fix this. Everyone is used to Cells staying at their respective positions as in this library : https://adazzle.github.io/react-data-grid/#/common-features

merabtenei avatar Feb 14 '24 11:02 merabtenei

in v5 this feature will be removed.

MichaelMatejko avatar Apr 24 '24 12:04 MichaelMatejko