reactgrid icon indicating copy to clipboard operation
reactgrid copied to clipboard

Published 20 hours ago • verified publisher icon silevis

Fix esc key for number cell

Open alonshmiel opened this issue 2 years ago • 1 comments

alonshmiel avatar Jul 06 '22 05:07 alonshmiel

Hi, I made a PR in the past that handles esc key in number cell (cancel the edit). I forgot the number cell so I added it to this PR.

This is the old PR that was merge. https://github.com/silevis/reactgrid/pull/97

alonshmiel avatar Jul 06 '22 07:07 alonshmiel

still doesn't work in number cells

dayron9408 avatar Nov 12 '22 18:11 dayron9408

Hi @dayron9408 , this PR was not merged yet. This is why it doesn't work. By the way, you can do what I did: you can use cell template and add the line of the blur event.

alon-shmiel-sage avatar Nov 14 '22 09:11 alon-shmiel-sage

Any chance this will be merged soon?

romanstetsyk avatar Mar 15 '23 17:03 romanstetsyk

Hi @romanstetsyk , I suggest you to create a custom template so you can add it to your template without waiting to this approval. It adds you more control. https://reactgrid.com/docs/4.0/7-api/0-interfaces/5-cell-template/

alonshmiel avatar Mar 15 '23 18:03 alonshmiel

@alonshmiel You're probably right. Thanks for the suggestion!

romanstetsyk avatar Mar 16 '23 21:03 romanstetsyk

@romanstetsyk , you're welcome :)

alon-shmiel-sage avatar Mar 16 '23 21:03 alon-shmiel-sage

I replaced your solution with a (hopefully) safer key press flag and merged the changes. It should now cancel the changes as expected.

DLowHP avatar Jul 31 '23 11:07 DLowHP