Silas Davis comments

Results 70 comments of


                                            Silas Davis

feat: Soften duplicate contract name in the case contracts have identical ABIs

I just want to put this out for a sense check before going to town on the rest of contribution requirements, let me know what you think.

feat: Soften duplicate contract name in the case contracts have identical ABIs

A bit more on why these duplicates might be seen from foundry, These snippets are are target from two duplicated foundry artifacts. the first appears under `out/`: ```json "compilationTarget": {...

feat: Soften duplicate contract name in the case contracts have identical ABIs

I've implemented a similar fix in the `foundry.ts` plugin source itself which I am using as a local vendored patch, let me know if you'd prefer that version.

Document how to resolve imports relative to an import root

Also hitting "protobuf/google/protobuf/descriptor.proto" not found exceptions. It looks like you include that in the repo should it be automatically be substituted?

Document how to resolve imports relative to an import root

Thanks for quick reply. I notice that the grpc package uses an older version of this library which I presume is why the following does seem to work: https://github.com/silasdavis/burrow/blob/protobuf.js/burrowjs/index.js Regarding...

Fix Typescript type checker errors

A hack that appears to work here: Merge into `tsconfig.json` ``` { "compilerOptions": { "typeRoots": ["./node_modules/@types", "**/node_modules/@types", "./@types"] } } ``` Add to root of repo: `@types/fhevmjs/index.d.ts`: ``` export *...

Fix Typescript type checker errors

Once you add the above incidentally you can see lots of type mismatches in `./test/instance.ts` and associated mocks

Fix Typescript type checker errors

Made a start in #583

clone behaviour of `yarn version`

as far as I can tell np does not support non-interactive use, as in CI, which is my use case for `yarn version`. This seems like a useful inclusion to...

fix: Use #!/usr/bin/env bash rather than #!/bin/bash

I think it was `s/Use/use` :), if so, done