reason-nodejs icon indicating copy to clipboard operation
reason-nodejs copied to clipboard

ChildProcess incorrect types

Open rdavison opened this issue 4 years ago • 4 comments

It appears Process and ChildProcess modules' stdin, stdout, and stderr values are all the opposite type from what they should be.

rdavison avatar Apr 12 '21 08:04 rdavison

Yes, stdout and stderr should be writable while stdin should be readable

banacorn avatar Jun 15 '21 06:06 banacorn

wondering if this repo is still being maintained

banacorn avatar Jun 15 '21 06:06 banacorn

Yes, stdout and stderr should be writable while stdin should be readable

isn't that already how it works? https://github.com/sikanhe/reason-nodejs/blob/b7b41349f85665d6cd7fc76a170229428e7ec94c/src/ChildProcess.re#L81-L86

I'm working on a fork that swaps to ReScript syntax and fixes any niggling little issues, but this one seems to have always been correct. [edit] now released as rescript-nodejs

TheSpyder avatar Sep 13 '21 09:09 TheSpyder

I see how I was wrong. Fixed in thespyder/rescript-nodejs#4.

TheSpyder avatar Nov 22 '21 02:11 TheSpyder