flarum-ext-pages icon indicating copy to clipboard operation
flarum-ext-pages copied to clipboard

Published 20 hours ago • verified publisher icon sijad

Update for Flarum beta 8

Open dsevillamartin opened this issue 6 years ago • 5 comments

Changes made:

  • Updated bootstrap.php to utilize new Extenders
    • Renamed to extend.php
  • Updated namespaces
  • Removed listeners in favor of Extenders
  • Updated icons to FA 5
  • Converted JS to Webpack structure
  • Simplified LESS files into 2 (one for forum, one for admin)
  • Added .gitattributes
  • Fixed isHtml not being sent to admin
    • Updated serializer to include isHtml
  • Fixed buttons in admin having extra padding

image image image

dsevillamartin avatar Sep 25 '18 23:09 dsevillamartin

there was a beta 8 branch in progress. but ill take a look at this soon

sijad avatar Sep 26 '18 03:09 sijad

@sijad Oh, I thought I checked. My apologies if I duplicated the work.

dsevillamartin avatar Sep 26 '18 19:09 dsevillamartin

could you please rebase this one with beta/8 branch?

sijad avatar Sep 27 '18 05:09 sijad

@sijad Hm, I tried but it was mostly just accepting my changes, as it's basically the same thing. I have fixed some FA 5 icons though.

I pushed a commit with your bootstrap.php formatting in extend.php, and made the serializing logic same as your branch. Not sure if you want the file to be renamed as you did.

dsevillamartin avatar Sep 27 '18 20:09 dsevillamartin

Any update on this?

dsevillamartin avatar Dec 31 '18 17:12 dsevillamartin