prom-client icon indicating copy to clipboard operation
prom-client copied to clipboard

benchmarks exhausting heap with engine >^16

Open jdmarshall opened this issue 6 months ago • 1 comments

npm run benchmarks consistently fails with OOM errors, on a machine with 64GB of memory.

  • node 24
  • node 22
  • node 20
  • node 18

All fail.

Only node 16 makes it through the first test and I can't imagine why.

Are you running these as part of the build process?

That is... problematic for a contribution I'd like to make, since IIRC it works better with the v8 version in Node 18.

jdmarshall avatar Jun 23 '25 20:06 jdmarshall

#658 increases the heap and allows Node 18 to be happy

jdmarshall avatar Jun 24 '25 01:06 jdmarshall

So I fixed the symptom. I did not fix the cause, and halfway through a walk I believe I understand why.

jdmarshall avatar Jul 08 '25 20:07 jdmarshall

#687 contains a fix for the obvious problem. Heap analysis didn’t turn up much else.

jdmarshall avatar Jul 09 '25 00:07 jdmarshall