sigstore-java icon indicating copy to clipboard operation
sigstore-java copied to clipboard

keep http params sigstore java user-agent up to date.

Open bobcallaway opened this issue 2 years ago • 4 comments

Description

It would be good for clients to be able to specify a User-Agent header on HTTP requests to sigstore services.

@loosebazooka

bobcallaway avatar Sep 02 '22 14:09 bobcallaway

this is already possible using httpParams: https://github.com/sigstore/sigstore-java/blob/main/sigstore-java/src/main/java/dev/sigstore/http/HttpParams.java

However we don't inject the version into there which is probably something we should do. @vlsi any ideas for injecting compile time vars (rather than reading the jar manifest?)

loosebazooka avatar Jan 03 '23 17:01 loosebazooka

WDYT of generating a class with the compile-time constants?

vlsi avatar Jan 03 '23 17:01 vlsi

I can replicate something like https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/version/org/postgresql/util/DriverInfo.java

vlsi avatar Jan 03 '23 17:01 vlsi

Yeah, lets do that. Let me know if you want someone else to pick it up. I can also do it.

loosebazooka avatar Jan 03 '23 18:01 loosebazooka

this was fixed with https://github.com/sigstore/sigstore-java/pull/728

loosebazooka avatar Aug 22 '24 22:08 loosebazooka