policy-controller icon indicating copy to clipboard operation
policy-controller copied to clipboard
verified publisher icon sigstore

Implement a simple in-mem cache (with opt-in).

Open vaikas opened this issue 2 years ago • 2 comments

A caching interface was implemented and by default it's implemented by just a placeholder. We should implement a simple in-memory cache to reduce hits on registry.

Interface: https://github.com/sigstore/policy-controller/blob/main/pkg/webhook/cache.go#L47

And then it should be injected into the context somewhere around here based on flags: https://github.com/sigstore/policy-controller/blob/main/cmd/webhook/main.go#L76

vaikas avatar Mar 07 '23 02:03 vaikas

@vaikas Should we include this issue into the v1 milestone ?

hectorj2f avatar Mar 08 '23 16:03 hectorj2f

I think we should do it even before :) But sure!

On Wed, Mar 8, 2023 at 8:35 AM Hector Fernandez @.***> wrote:

@vaikas https://github.com/vaikas Should we include this issue into the v1 milestone ?

— Reply to this email directly, view it on GitHub https://github.com/sigstore/policy-controller/issues/647#issuecomment-1460468724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWB45HU66KAEUDUFC5W6B3W3CYM5ANCNFSM6AAAAAAVR4LFEA . You are receiving this because you were mentioned.Message ID: @.***>

vaikas avatar Mar 08 '23 16:03 vaikas