helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon sigstore

Expose the deployment strategy values for the policy controller

Open shearn89 opened this issue 9 months ago • 1 comments

Description of the change

Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default maxSurge: 25% being rounded down to 0.

This change exposes those values, so that the maxSurge can be updated and a single instance can be rolled.

Existing or Associated Issue(s)

Fixes #748.

Additional Information

Checklist

  • [x] Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • [x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • [ ] JSON Schema generated.
  • [ ] List tests pass for Chart using the Chart Testing tool and the ct lint command.

shearn89 avatar May 07 '24 13:05 shearn89

can you rebase and sign the dco?

cpanato avatar Jun 27 '24 09:06 cpanato

@shearn89 thanks for adding this feature. Could you do the necessary to get this merged please?

vipulagarwal avatar Oct 04 '24 21:10 vipulagarwal

Sorry, it's been busy at work and home. I'll try to get this ready for merging soon.

shearn89 avatar Oct 09 '24 07:10 shearn89

Okay - rebased, updated, linted, schema generated, and commits signed off!

If you'd like me to squash the commits or squash-merge, let me know. 😁

shearn89 avatar Oct 10 '24 07:10 shearn89